Quantcast
Viewing all articles
Browse latest Browse all 52618

Incompatible changes in HtmlUtil.groovy between 4.5.1 and 4.5.2

This is in method HtmlUtil.urlFor(opts)
4.5.1:

        qparams += opts
        def addedParam = false
        for (o in qparams) {
            if (!addedParam)
                res += '?'
            res += "${o.key}=${escapeHtml(o.value)}&"
            addedParam = true
        }


4.5.2 :

        qparams += opts
        def addedParam = false
        for (o in qparams) {
            if (!addedParam)
                res += '?'
         else
             res += '&'
            res += "${o.key}=${escapeHtml(o.value)}"
            addedParam = true
        }


Technically, the 4.5.2 version is better because it strips away the trailing ampersand (which is only a cosmetic improvement, actually). However, if you have an existing HQU plugin deployed in earlier version of Hyperic, where there is code that appends more parameters to a URL previously returned by a call to urlFor(), chances are that it will be broken after upgrading to 4.5.2.

Viewing all articles
Browse latest Browse all 52618

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>